From 2f17449dff3272e08f509e0f06aa08d3acf7e105 Mon Sep 17 00:00:00 2001 From: Parshintsev Anatoly Date: Tue, 5 Sep 2023 21:08:02 +0300 Subject: [PATCH] target: return error if attempting to access non-existing registers Change-Id: Ic22edcab46d21dbc71f78275a78bdea9c2bcc394 Signed-off-by: Parshintsev Anatoly Reviewed-on: https://review.openocd.org/c/openocd/+/7886 Reviewed-by: Tim Newsome Reviewed-by: Jan Matyas Reviewed-by: Marek Vrbka Reviewed-by: Antonio Borneo Tested-by: jenkins --- src/target/target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/target/target.c b/src/target/target.c index 121974375..acd351a66 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -3116,7 +3116,7 @@ COMMAND_HANDLER(handle_reg_command) if (!reg) { command_print(CMD, "%i is out of bounds, the current target " "has only %i registers (0 - %i)", num, count, count - 1); - return ERROR_OK; + return ERROR_FAIL; } } else { /* access a single register by its name */ @@ -3175,7 +3175,7 @@ COMMAND_HANDLER(handle_reg_command) not_found: command_print(CMD, "register %s not found in current target", CMD_ARGV[0]); - return ERROR_OK; + return ERROR_FAIL; } COMMAND_HANDLER(handle_poll_command)