root/openocd
2
0
Fork 0
mirror of git://git.code.sf.net/p/openocd/code synced 2025-08-15 15:33:46 +10:00
Code Issues Releases Wiki Activity

target: improve error messaging in target create

Browse Source 
There are a couple of issues with the usage string for `target create`,
namely:
* `-chain-position` is allowed to be not the first option.
* `-chain-position` should be ommited alltogether on ARM targets when
  DAP is specified.

Before the patch:
```
> openocd -c 'target create name testee'
...
  target create name type '-chain-position' name [options ...]
```

After the patch:
```
> openocd -c 'target create name testee'
...
-chain-position ?name? required when creating target
> openocd -c 'target create'
...
  target create name type [options ...]
```

Change-Id: Ia21a99ce6a4086e2e0676f5ef4685da3514a4f69
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8860
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
This commit is contained in:
Evgeniy Naydanov 2025-04-28 16:46:08 +03:00 committed by Antonio Borneo
parent d6c54b9494
commit 8c09cc2c17
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/target/target.c
View File

@ -5706,7 +5706,7 @@ COMMAND_HANDLER(handle_target_create)
int retval = ERROR_OK;
int x;
if (CMD_ARGC < 4)
if (CMD_ARGC < 2)
return ERROR_COMMAND_SYNTAX_ERROR;
/* check if the target name clashes with an existing command name */
@ -6051,7 +6051,7 @@ static const struct command_registration target_subcommand_handlers[] = {
.name = "create",
.mode = COMMAND_CONFIG,
.handler = handle_target_create,
.usage = "name type '-chain-position' name [options ...]",
.usage = "name type [options ...]",
.help = "Creates and selects a new target",
},
{