2
0
mirror of git://git.code.sf.net/p/openocd/code synced 2025-08-07 06:26:38 +10:00
openocd/src/target
Antonio Borneo 63e22d5fb9 arm_adi_v5: fix scan-build warning [1/3]
Commit 21f7885d1c ("arm_adi_v5: separate ROM table parsing from
command output [1/3]") introduces a new scan-build warning because
continues the execution even when dap_get_debugbase() returns
error. The value of 'apid' can be uninitialized:

	5th function call argument is an uninitialized value

Check the return value and quit on error.
While there, remove the useless initialization of 'dbgbase' that
was apparently required for the same problem.

Change-Id: Iade26a152925ee0f1bf114ed829b94f7ed5b254f
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Fixes: 21f7885d1c ("arm_adi_v5: separate ROM table parsing from command output [1/3]")
Reviewed-on: https://review.openocd.org/c/openocd/+/7010
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
2022-06-10 21:54:01 +00:00
..
espressif target: add Espressif ESP32-S2 basic support 2022-06-04 08:18:44 +00:00
openrisc target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
riscv target/riscv: drop unused variable registers_initialized 2022-06-04 08:20:09 +00:00
xtensa target: add Espressif ESP32-S2 basic support 2022-06-04 08:18:44 +00:00
a64_disassembler.c target/disassembler: update capstone include path to <capstone.h> 2022-04-30 17:53:30 +00:00
a64_disassembler.h target/aarch64: a64 disassembler 2020-10-03 11:21:15 +01:00
aarch64.c aarch64: don't wait for smp targets halted in deassert reset 2022-05-14 08:57:36 +00:00
aarch64.h target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
adi_v5_dapdirect.c
adi_v5_jtag.c adi_v5_jtag: reduce verbosity on persistent WAIT 2022-05-14 08:43:30 +00:00
adi_v5_swd.c adi_v5_swd: add jtag-to-swd through dormant 2021-12-11 17:39:58 +00:00
algorithm.c
algorithm.h Cleanup of config/includes. 2021-05-01 14:35:09 +01:00
arc_cmd.c helper/jim-nvp: comply with coding style [2/2] 2021-06-04 17:40:48 +01:00
arc_cmd.h
arc_jtag.c openocd: fix doxygen parameters of functions 2021-01-13 11:33:53 +00:00
arc_jtag.h
arc_mem.c openocd: fix simple cases of Yoda condition 2021-07-20 14:55:24 +01:00
arc_mem.h
arc.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
arc.h target: fix some minor typo 2021-05-22 10:06:45 +01:00
arm7_9_common.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
arm7_9_common.h
arm7tdmi.c target/arm: optimize architecture flags 2021-06-18 23:12:54 +01:00
arm7tdmi.h
arm9tdmi.c target/arm: optimize architecture flags 2021-06-18 23:12:54 +01:00
arm9tdmi.h
arm11_dbgtap.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
arm11_dbgtap.h target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
arm11.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
arm11.h
arm720t.c target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
arm720t.h
arm920t.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
arm920t.h
arm926ejs.c target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
arm926ejs.h target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
arm946e.c target: declare local symbols as static 2020-11-04 17:39:17 +00:00
arm946e.h
arm966e.c target: use proper format with uint32_t 2020-09-05 17:12:39 +01:00
arm966e.h
arm_adi_v5.c arm_adi_v5: fix scan-build warning [1/3] 2022-06-10 21:54:01 +00:00
arm_adi_v5.h arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase 2022-05-14 08:55:33 +00:00
arm_coresight.h arm_adi_v5: replace dap_lookup_cs_component() 2022-05-14 08:55:52 +00:00
arm_cti.c target/arm_cti: Fix error handling in 'cti create' 2022-04-30 17:52:40 +00:00
arm_cti.h
arm_dap.c openocd: use unique name for struct command_registration 2021-11-23 11:04:02 +00:00
arm_disassembler.c target/disassembler: update capstone include path to <capstone.h> 2022-04-30 17:53:30 +00:00
arm_disassembler.h target/arm: opcodes: rename CamelCase symbols and uppercase variables 2021-07-20 14:52:49 +01:00
arm_dpm.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
arm_dpm.h target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
arm_jtag.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
arm_jtag.h target/arm_jtag.h: fix wrong comparison in arm_jtag_set_instr 2021-12-11 17:49:30 +00:00
arm_opcodes.h target/arm: opcodes: rename CamelCase symbols and uppercase variables 2021-07-20 14:52:49 +01:00
arm_semihosting.c semihosting: User defined operation, Tcl command exec on host 2022-02-05 21:40:17 +00:00
arm_semihosting.h
arm_simulator.c target/arm: opcodes: rename CamelCase symbols and uppercase variables 2021-07-20 14:52:49 +01:00
arm_simulator.h
arm_tpiu_swo.c arm_tpiu_swo: fix autodetection of SWO pin frequency 2022-03-26 13:23:40 +00:00
arm_tpiu_swo.h armv7m_trace: get rid of the old tpiu code 2021-03-10 21:34:04 +00:00
arm.h openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
armv4_5_cache.c
armv4_5_cache.h Cleanup of config/includes. 2021-05-01 14:35:09 +01:00
armv4_5_mmu.c
armv4_5_mmu.h
armv4_5.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
armv4_5.h
armv7a_cache_l2x.c target/smp: use a struct list_head to hold the smp targets 2022-02-14 15:10:10 +00:00
armv7a_cache_l2x.h
armv7a_cache.c target/smp: use a struct list_head to hold the smp targets 2022-02-14 15:10:10 +00:00
armv7a_cache.h target: use proper format with uint32_t 2020-09-05 17:12:39 +01:00
armv7a_mmu.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
armv7a_mmu.h
armv7a.c cortex_a: get rid of not needed log messages 2022-06-03 23:46:21 +00:00
armv7a.h target/adiv5: Large Physical Address Extension 2021-07-02 17:12:11 +01:00
armv7m_trace.c armv7m_trace: get rid of the old tpiu code 2021-03-10 21:34:04 +00:00
armv7m_trace.h helper: Remove src/helper from include dirs 2021-10-02 13:18:15 +00:00
armv7m.c target/cortex_m: faster reading of all CPU registers 2021-11-18 21:09:34 +00:00
armv7m.h target/armv7m,cortex_m: introduce checked arch_info cast routines 2022-02-25 19:56:41 +00:00
armv8_cache.c target/smp: use a struct list_head to hold the smp targets 2022-02-14 15:10:10 +00:00
armv8_cache.h
armv8_dpm.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
armv8_dpm.h target/aarch64: fix watchpoint management 2021-05-22 10:04:20 +01:00
armv8_opcodes.c
armv8_opcodes.h target/arm: opcodes: rename CamelCase symbols and uppercase variables 2021-07-20 14:52:49 +01:00
armv8.c aarch64: support for aarch32 ARM_MODE_UND 2022-01-29 18:20:48 +00:00
armv8.h target/adiv5: Large Physical Address Extension 2021-07-02 17:12:11 +01:00
avr32_ap7k.c target: rename CamelCase symbols 2021-07-24 10:37:25 +01:00
avr32_ap7k.h target: rename CamelCase symbols 2021-07-24 10:37:25 +01:00
avr32_jtag.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
avr32_jtag.h
avr32_mem.c target: fix some minor typo 2021-05-22 10:06:45 +01:00
avr32_mem.h
avr32_regs.c
avr32_regs.h
avrt.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
avrt.h
breakpoints.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
breakpoints.h breakpoints: fix build on -fno-inline 2022-03-19 11:35:32 +00:00
cortex_a.c arm_adi_v5: let dap_lookup_cs_component() to get AP dbgbase 2022-05-14 08:55:33 +00:00
cortex_a.h target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
cortex_m.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
cortex_m.h target/cortex_m: add Cortex-M part number getter 2022-02-25 20:26:56 +00:00
dsp563xx_once.c
dsp563xx_once.h
dsp563xx.c target: rename CamelCase symbols 2021-07-24 10:37:25 +01:00
dsp563xx.h target/dsp563xx: Use bool data type for 'hardware_breakpoints_cleared' 2021-06-26 14:40:34 +01:00
dsp5680xx.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
dsp5680xx.h target: rename CamelCase symbols 2021-07-24 10:37:25 +01:00
embeddedice.c jtag: remove minidriver code and minidriver-dummy 2021-03-19 21:56:06 +00:00
embeddedice.h target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
esirisc_jtag.c openocd: remove NULL comparisons with checkpatch [1/2] 2021-07-24 10:38:00 +01:00
esirisc_jtag.h
esirisc_regs.h target: rename CamelCase symbols 2021-07-24 10:37:25 +01:00
esirisc_trace.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
esirisc_trace.h
esirisc.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
esirisc.h target: rename CamelCase symbols 2021-07-24 10:37:25 +01:00
etb.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
etb.h
etm_dummy.c
etm_dummy.h
etm.c openocd: use single line for register_commands*() 2021-11-23 11:03:38 +00:00
etm.h
fa526.c
feroceon.c target/arm: rename CamelCase symbols 2021-07-20 14:52:25 +01:00
hla_target.c target/hla_target: set cortex_m->common_magic 2021-11-25 09:47:28 +00:00
image.c target/image: fix - p_flags field in ELF64 segment headers is 64 bits wide 2022-04-23 09:26:15 +00:00
image.h target/image: fix - p_flags field in ELF64 segment headers is 64 bits wide 2022-04-23 09:26:15 +00:00
lakemont.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
lakemont.h
ls1_sap.c openocd: remove NULL comparisons with checkpatch [1/2] 2021-07-24 10:38:00 +01:00
Makefile.am target: add Espressif ESP32-S2 basic support 2022-06-04 08:18:44 +00:00
mem_ap.c openocd: remove NULL comparisons with checkpatch [1/2] 2021-07-24 10:38:00 +01:00
mips32_dmaacc.c
mips32_dmaacc.h
mips32_pracc.c jtag: align adapter speed code to new structure 2021-11-13 10:50:34 +00:00
mips32_pracc.h target/mips: Remove typedef'd struct 2021-03-10 21:30:04 +00:00
mips32.c Use boolean argument for register_get_by_name() 2021-06-18 23:14:27 +01:00
mips32.h target/mips: rename CamelCase symbols 2021-07-20 14:53:03 +01:00
mips64_pracc.c jtag: align adapter speed code to new structure 2021-11-13 10:50:34 +00:00
mips64_pracc.h
mips64.c
mips64.h
mips_ejtag.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
mips_ejtag.h target/mips: rename CamelCase symbols 2021-07-20 14:53:03 +01:00
mips_m4k.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
mips_m4k.h
mips_mips64.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
mips_mips64.h
nds32_aice.c openocd: remove NULL comparisons with checkpatch [1/2] 2021-07-24 10:38:00 +01:00
nds32_aice.h
nds32_cmd.c openocd: fix Yoda conditions with checkpatch 2021-07-24 10:38:31 +01:00
nds32_cmd.h
nds32_disassembler.c openocd: manually fix Yoda conditions 2021-07-20 14:55:43 +01:00
nds32_disassembler.h
nds32_edm.h Cleanup of config/includes. 2021-05-01 14:35:09 +01:00
nds32_insn.h target/nds32: use lowercase for C variables 2021-07-20 14:54:27 +01:00
nds32_reg.c target: use proper format with uint32_t 2020-09-05 17:12:39 +01:00
nds32_reg.h
nds32_tlb.c target/nds32: rename CamelCase symbols 2021-07-20 14:53:12 +01:00
nds32_tlb.h target/nds32: rename CamelCase symbols 2021-07-20 14:53:12 +01:00
nds32_v2.c openocd: fix Yoda conditions with checkpatch 2021-07-24 10:38:31 +01:00
nds32_v2.h
nds32_v3_common.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
nds32_v3_common.h
nds32_v3.c openocd: fix simple cases of Yoda condition 2021-07-20 14:55:24 +01:00
nds32_v3.h
nds32_v3m.c openocd: fix simple cases of Yoda condition 2021-07-20 14:55:24 +01:00
nds32_v3m.h
nds32.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
nds32.h openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
quark_d20xx.c openocd: fix simple cases of NULL comparison 2021-07-24 10:37:49 +01:00
quark_x10xx.c
register.c target/register: Minor code cleanup 2021-06-18 23:14:09 +01:00
register.h Cleanup of config/includes. 2021-05-01 14:35:09 +01:00
rtt.c openocd: include config.h in every file .c 2022-03-26 13:32:57 +00:00
rtt.h Add initial RTT support 2020-12-02 23:15:52 +00:00
semihosting_common.c semihosting: add semihosting_basedir command 2022-05-21 09:01:56 +00:00
semihosting_common.h semihosting: add semihosting_basedir command 2022-05-21 09:01:56 +00:00
smp.c smp: deprecate legacy SMP core switching support 2022-05-07 11:00:00 +00:00
smp.h smp: deprecate legacy SMP core switching support 2022-05-07 11:00:00 +00:00
startup.tcl target: Deprecate 'array2mem' and 'mem2array'' 2022-03-12 09:48:00 +00:00
stm8.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
stm8.h target/stm8: Make 'stm8_command_handlers' static 2021-05-08 09:49:32 +01:00
target_request.c openocd: manually remove NULL comparisons 2021-07-24 10:38:19 +01:00
target_request.h
target_type.h target: document possibly unreachable target in deinit_target() 2022-05-07 11:04:45 +00:00
target.c target: add Espressif ESP32-S2 basic support 2022-06-04 08:18:44 +00:00
target.h Give each SMP group a unique number. 2022-05-27 22:52:35 +00:00
testee.c
trace.c target: avoid checking for non NULL pointer to free it 2020-09-05 20:47:11 +01:00
trace.h Cleanup of config/includes. 2021-05-01 14:35:09 +01:00
x86_32_common.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
x86_32_common.h
xscale.c target: Rework 'set' variable of break-/watchpoints 2022-03-19 09:14:39 +00:00
xscale.h