stuartl/linux-mainline
1
0
Fork 0
mirror of https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux synced 2025-09-15 00:56:46 +10:00
Code Issues Releases Wiki Activity

slimbus: qcom-ngd: Fix kfree() of static memory on setting driver_override

Browse Source 
The driver_override field from platform driver should not be initialized
from static memory (string literal) because the core later kfree() it,
for example when driver_override is set via sysfs.

Use dedicated helper to set driver_override properly.

Fixes: 917809e228 ("slimbus: ngd: Add qcom SLIMBus NGD driver")
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220419113435.246203-11-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Krzysztof Kozlowski 2022-04-19 13:34:33 +02:00 committed by Greg Kroah-Hartman
parent fb4ac6f18b
commit 0f4b20ef41
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/slimbus/qcom-ngd-ctrl.c
View File

@ -1434,6 +1434,7 @@ static int of_qcom_slim_ngd_register(struct device *parent,
const struct of_device_id *match; const struct of_device_id *match;
struct device_node *node; struct device_node *node;
u32 id; u32 id;
int ret;
match = of_match_node(qcom_slim_ngd_dt_match, parent->of_node); match = of_match_node(qcom_slim_ngd_dt_match, parent->of_node);
data = match->data; data = match->data;
@ -1455,7 +1456,17 @@ static int of_qcom_slim_ngd_register(struct device *parent,
} }
ngd->id = id; ngd->id = id;
ngd->pdev->dev.parent = parent; ngd->pdev->dev.parent = parent;
ngd->pdev->driver_override = QCOM_SLIM_NGD_DRV_NAME;
ret = driver_set_override(&ngd->pdev->dev,
&ngd->pdev->driver_override,
QCOM_SLIM_NGD_DRV_NAME,
strlen(QCOM_SLIM_NGD_DRV_NAME));
if (ret) {
platform_device_put(ngd->pdev);
kfree(ngd);
of_node_put(node);
return ret;
}
ngd->pdev->dev.of_node = node; ngd->pdev->dev.of_node = node;
ctrl->ngd = ngd; ctrl->ngd = ngd;