mirror of
				https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux
				synced 2025-11-04 08:34:47 +10:00 
			
		
		
		
	SELinux: null-terminate context string in selinux_xfrm_sec_ctx_alloc
xfrm_audit_log() expects the context string to be null-terminated which currently doesn't happen with user-supplied contexts. Signed-off-by: Venkat Yekkirala <vyekkirala@TrustedCS.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
		
							parent
							
								
									0de085bb47
								
							
						
					
					
						commit
						910949a668
					
				@ -216,7 +216,7 @@ static int selinux_xfrm_sec_ctx_alloc(struct xfrm_sec_ctx **ctxp,
 | 
			
		||||
		return -ENOMEM;
 | 
			
		||||
 | 
			
		||||
	*ctxp = ctx = kmalloc(sizeof(*ctx) +
 | 
			
		||||
			      uctx->ctx_len,
 | 
			
		||||
			      uctx->ctx_len + 1,
 | 
			
		||||
			      GFP_KERNEL);
 | 
			
		||||
 | 
			
		||||
	if (!ctx)
 | 
			
		||||
@ -229,6 +229,7 @@ static int selinux_xfrm_sec_ctx_alloc(struct xfrm_sec_ctx **ctxp,
 | 
			
		||||
	memcpy(ctx->ctx_str,
 | 
			
		||||
	       uctx+1,
 | 
			
		||||
	       ctx->ctx_len);
 | 
			
		||||
	ctx->ctx_str[ctx->ctx_len] = 0;
 | 
			
		||||
	rc = security_context_to_sid(ctx->ctx_str,
 | 
			
		||||
				     ctx->ctx_len,
 | 
			
		||||
				     &ctx->ctx_sid);
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user