linux-mainline/net/devlink
Michal Swiatkowski f3b97b7d4b devlink: fix xa_alloc_cyclic() error handling
In case of returning 1 from xa_alloc_cyclic() (wrapping) ERR_PTR(1) will
be returned, which will cause IS_ERR() to be false. Which can lead to
dereference not allocated pointer (rel).

Fix it by checking if err is lower than zero.

This wasn't found in real usecase, only noticed. Credit to Pierre.

Fixes: c137743bce ("devlink: introduce object and nested devlink relationship infra")
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2025-03-19 09:57:36 +00:00
..
core.c devlink: fix xa_alloc_cyclic() error handling 2025-03-19 09:57:36 +00:00
dev.c net: convert to nla_get_*_default() 2024-11-11 10:32:06 -08:00
devl_internal.h devlink: introduce devlink_nl_put_u64() 2024-10-29 16:52:56 -07:00
dpipe.c devlink: use devlink_nl_put_u64() helper 2024-10-29 16:52:56 -07:00
health.c devlink: add devlink_fmsg_dump_skb() function 2024-12-17 09:32:08 -08:00
linecard.c
Makefile
netlink_gen.c
netlink_gen.h
netlink.c
param.c
port.c devlink: Improve the port attributes description 2025-01-02 17:10:57 -08:00
rate.c devlink: use devlink_nl_put_u64() helper 2024-10-29 16:52:56 -07:00
region.c devlink: region: snapshot IDs: consolidate error values 2024-10-29 16:52:57 -07:00
resource.c devlink: remove unused devlink_resource_register() 2024-10-29 16:52:57 -07:00
sb.c
trap.c devlink: use devlink_nl_put_u64() helper 2024-10-29 16:52:56 -07:00