Baolin Wang 1c06b6a599 mm: compaction: fix the possible deadlock when isolating hugetlb pages ... When trying to isolate a migratable pageblock, it can contain several normal pages or several hugetlb pages (e.g. CONT-PTE 64K hugetlb on arm64) in a pageblock. That means we may hold the lru lock of a normal page to continue to isolate the next hugetlb page by isolate_or_dissolve_huge_page() in the same migratable pageblock. However in the isolate_or_dissolve_huge_page(), it may allocate a new hugetlb page and dissolve the old one by alloc_and_dissolve_hugetlb_folio() if the hugetlb's refcount is zero. That means we can still enter the direct compaction path to allocate a new hugetlb page under the current lru lock, which may cause possible deadlock. To avoid this possible deadlock, we should release the lru lock when trying to isolate a hugetbl page. Moreover it does not make sense to take the lru lock to isolate a hugetlb, which is not in the lru list. Link: https://lkml.kernel.org/r/7ab3bffebe59fb419234a68dec1e4572a2518563.1678962352.git.baolin.wang@linux.alibaba.com Fixes: 369fa227c2 ("mm: make alloc_contig_range handle free hugetlb pages") Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com> Acked-by: Mel Gorman <mgorman@techsingularity.net> Cc: Oscar Salvador <osalvador@suse.de> Cc: William Lam <william.lam@bytedance.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2023-04-05 19:42:50 -07:00
..
damon	mm/damon/paddr: fix folio_nr_pages() after folio_put() in damon_pa_mark_accessed_or_deactivate()	2023-03-07 17:04:55 -08:00
kasan	kasan: suppress recursive reports for HW_TAGS	2023-04-05 19:42:43 -07:00
kfence	mm: kfence: fix handling discontiguous page	2023-03-28 15:24:32 -07:00
kmsan	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
backing-dev.c
balloon_compaction.c
bootmem_info.c
cma_debug.c
cma_sysfs.c	mm: cma: make kobj_type structure constant	2023-03-28 16:20:06 -07:00
cma.c	mm/cma: fix potential memory loss on cma_declare_contiguous_nid	2023-02-02 22:33:24 -08:00
cma.h
compaction.c	mm: compaction: fix the possible deadlock when isolating hugetlb pages	2023-04-05 19:42:50 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
debug.c	mm/debug: use %pGt to display page_type in dump_page()	2023-03-28 16:20:09 -07:00
dmapool_test.c	dmapool: add alloc/free performance test	2023-04-05 19:42:38 -07:00
dmapool.c	dmapool: create/destroy cleanup	2023-04-05 19:42:41 -07:00
early_ioremap.c
fadvise.c
failslab.c
filemap.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
folio-compat.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
frontswap.c
gup_test.c
gup_test.h
gup.c	mm/gup.c: fix typo in comments	2023-03-28 16:20:14 -07:00
highmem.c
hmm.c
huge_memory.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
hugetlb_cgroup.c	mm/hugetlb: increase use of folios in alloc_huge_page()	2023-02-13 15:54:27 -08:00
hugetlb_vmemmap.c	mm: prefer xxx_page() alloc/free functions for order-0 pages	2023-03-28 16:20:16 -07:00
hugetlb_vmemmap.h
hugetlb.c	mm: userfaultfd: combine 'mode' and 'wp_copy' arguments	2023-04-05 19:42:48 -07:00
hwpoison-inject.c
init-mm.c
internal.h	mm, printk: introduce new format %pGt for page_type	2023-03-28 16:20:09 -07:00
interval_tree.c
io-mapping.c
ioremap.c
Kconfig	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
Kconfig.debug	mm: move KMEMLEAK's Kconfig items from lib to mm	2023-02-02 22:33:26 -08:00
khugepaged.c	mm/uffd: UFFD_FEATURE_WP_UNPOPULATED	2023-04-05 19:42:44 -07:00
kmemleak.c	lib/stackdepot, mm: rename stack_depot_want_early_init	2023-02-16 20:43:49 -08:00
ksm.c	mm: add tracepoints to ksm	2023-03-28 16:20:08 -07:00
list_lru.c
maccess.c
madvise.c	- Daniel Verkamp has contributed a memfd series ("mm/memfd: add	2023-02-23 17:09:35 -08:00
Makefile	dmapool: add alloc/free performance test	2023-04-05 19:42:38 -07:00
mapping_dirty_helpers.c
memblock.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
memcontrol.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
memfd.c
memory_hotplug.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
memory-failure.c	mm: memory-failure: directly use IS_ENABLED(CONFIG_HWPOISON_INJECT)	2023-03-28 16:20:17 -07:00
memory-tiers.c	memory tier: release the new_memtier in find_create_memory_tier()	2023-02-09 16:51:40 -08:00
memory.c	mm/uffd: UFFD_FEATURE_WP_UNPOPULATED	2023-04-05 19:42:44 -07:00
mempolicy.c	mm: hugetlb: change to return bool for isolate_hugetlb()	2023-02-20 12:46:17 -08:00
mempool.c
memremap.c	mm/memremap.c: fix outdated comment in devm_memremap_pages	2023-02-09 16:51:46 -08:00
memtest.c
migrate_device.c	mm: change to return bool for isolate_lru_page()	2023-02-20 12:46:17 -08:00
migrate.c	mm/migrate: drop pte_mkhuge() in remove_migration_pte()	2023-03-28 16:20:11 -07:00
mincore.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
mlock.c	mm: introduce vm_flags_reset_once to replace WRITE_ONCE vm_flags updates	2023-02-09 16:51:41 -08:00
mm_init.c
mm_slot.h
mmap_lock.c
mmap.c	mm/mmap: start distinguishing if vma can be removed in mergeability test	2023-04-05 19:42:50 -07:00
mmu_gather.c	mm: prefer xxx_page() alloc/free functions for order-0 pages	2023-03-28 16:20:16 -07:00
mmu_notifier.c
mmzone.c
mprotect.c	mm/uffd: UFFD_FEATURE_WP_UNPOPULATED	2023-04-05 19:42:44 -07:00
mremap.c	mm/mremap: simplify vma expansion again	2023-04-05 19:42:50 -07:00
msync.c
nommu.c	mm: replace vma->vm_flags direct modifications with modifier calls	2023-02-09 16:51:39 -08:00
oom_kill.c
page_alloc.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
page_counter.c
page_ext.c	mm/page_ext: init page_ext early if there are no deferred struct pages	2023-02-02 22:33:22 -08:00
page_idle.c
page_io.c	- Daniel Verkamp has contributed a memfd series ("mm/memfd: add	2023-02-23 17:09:35 -08:00
page_isolation.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
page_owner.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
page_poison.c
page_reporting.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
page_reporting.h
page_table_check.c	mm/page_ext: do not allocate space for page_ext->flags if not needed	2023-02-02 22:33:11 -08:00
page_vma_mapped.c
page-writeback.c	mm,jfs: move write_one_page/folio_write_one to jfs	2023-03-28 16:20:14 -07:00
pagewalk.c
percpu-internal.h	mm: percpu: fix incorrect size in pcpu_obj_full_size()	2023-02-16 20:43:55 -08:00
percpu-km.c
percpu-stats.c
percpu-vm.c
percpu.c	mm: memcontrol: rename memcg_kmem_enabled()	2023-02-16 20:43:56 -08:00
pgalloc-track.h
pgtable-generic.c	mm: add PTE pointer parameter to flush_tlb_fix_spurious_fault()	2023-03-28 16:20:12 -07:00
process_vm_access.c
ptdump.c
readahead.c	readahead: convert readahead_expand() to use a folio	2023-02-02 22:33:21 -08:00
rmap.c	mm/rmap: use atomic_try_cmpxchg in set_tlb_ubc_flush_pending	2023-03-28 16:20:09 -07:00
rodata_test.c
secretmem.c	- Daniel Verkamp has contributed a memfd series ("mm/memfd: add	2023-02-23 17:09:35 -08:00
shmem.c	mm: userfaultfd: combine 'mode' and 'wp_copy' arguments	2023-04-05 19:42:48 -07:00
shrinker_debug.c	mm: shrinkers: convert shrinker_rwsem to mutex	2023-03-28 16:20:17 -07:00
shuffle.c
shuffle.h	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
slab_common.c
slab.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
slab.h	mm: memcontrol: rename memcg_kmem_enabled()	2023-02-16 20:43:56 -08:00
slob.c
slub.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
sparse-vmemmap.c
sparse.c	mm/sparse: fix "unused function 'pgdat_to_phys'" warning	2023-02-02 22:33:29 -08:00
swap_cgroup.c
swap_slots.c
swap_state.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
swap.c	- Daniel Verkamp has contributed a memfd series ("mm/memfd: add	2023-02-23 17:09:35 -08:00
swap.h	mm: remove the __swap_writepage return value	2023-02-02 22:33:33 -08:00
swapfile.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
truncate.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
usercopy.c
userfaultfd.c	mm: userfaultfd: add UFFDIO_CONTINUE_MODE_WP to install WP PTEs	2023-04-05 19:42:48 -07:00
util.c	mm: fix typo in __vm_enough_memory warning	2023-02-13 15:54:33 -08:00
vmalloc.c	mm: prefer xxx_page() alloc/free functions for order-0 pages	2023-03-28 16:20:16 -07:00
vmpressure.c
vmscan.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
vmstat.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
workingset.c	swap_state: update shadow_nodes for anonymous page	2023-02-02 22:33:24 -08:00
z3fold.c
zbud.c
zpool.c
zsmalloc.c	zsmalloc: show per fullness group class stats	2023-03-28 16:20:12 -07:00
zswap.c	mm/zswap: try to avoid worst-case scenario on same element pages	2023-03-28 16:20:07 -07:00