linux-mainline/tools/testing/selftests/net
Fathi Boudra 870f193d48 selftests: net: use LDLIBS instead of LDFLAGS
reuseport_bpf_numa fails to build due to undefined reference errors:

 aarch64-linaro-linux-gcc
 --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall
 -Wl,--no-as-needed -O2 -g -I../../../../usr/include/  -Wl,-O1
 -Wl,--hash-style=gnu -Wl,--as-needed -lnuma  reuseport_bpf_numa.c
 -o
 /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa
 /tmp/ccfUuExT.o: In function `send_from_node':
 /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138:
 undefined reference to `numa_run_on_node'
 /tmp/ccfUuExT.o: In function `main':
 /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230:
 undefined reference to `numa_available'
 /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233:
 undefined reference to `numa_max_node'

It's GNU Make and linker specific.

The default Makefile rule looks like:

$(CC) $(CFLAGS) $(LDFLAGS) $@ $^ $(LDLIBS)

When linking is done by gcc itself, no issue, but when it needs to be passed
to proper ld, only LDLIBS follows and then ld cannot know what libs to link
with.

More detail:
https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

LDFLAGS
Extra flags to give to compilers when they are supposed to invoke the linker,
‘ld’, such as -L. Libraries (-lfoo) should be added to the LDLIBS variable
instead.

LDLIBS
Library flags or names given to compilers when they are supposed to invoke the
linker, ‘ld’. LOADLIBES is a deprecated (but still supported) alternative to
LDLIBS. Non-library linker flags, such as -L, should go in the LDFLAGS
variable.

https://lkml.org/lkml/2010/2/10/362

tools/perf: libraries must come after objects

Link order matters, use LDLIBS instead of LDFLAGS to properly link against
libnuma.

Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
Signed-off-by: Shuah Khan <shuah@kernel.org>
2019-01-28 08:02:12 -07:00
..
forwarding selftests: forwarding: Add router test with VID 1 2018-12-20 15:48:54 -08:00
.gitignore selftests: net: test that listening sockets match on address properly 2018-12-14 15:55:20 -08:00
config selftests: explicitly require kernel features needed by udpgro tests 2018-11-22 11:35:28 -08:00
fib_rule_tests.sh
fib_tests.sh
fib-onlink-tests.sh
in_netns.sh
ip6_gre_headroom.sh
ip_defrag.c
ip_defrag.sh
Makefile selftests: net: use LDLIBS instead of LDFLAGS 2019-01-28 08:02:12 -07:00
msg_zerocopy.c selftests: extend zerocopy tests to udp 2018-12-03 15:58:32 -08:00
msg_zerocopy.sh selftests: extend zerocopy tests to udp 2018-12-03 15:58:32 -08:00
netdevice.sh
pmtu.sh selftests: pmtu: Introduce FoU and GUE PMTU exceptions tests 2018-11-08 17:13:08 -08:00
psock_fanout.c
psock_lib.h
psock_snd.c
psock_snd.sh
psock_tpacket.c
reuseaddr_conflict.c
reuseport_addr_any.c selftests: net: reuseport_addr_any: silence clang warning 2018-12-20 19:26:52 -08:00
reuseport_addr_any.sh selftests: net: test that listening sockets match on address properly 2018-12-14 15:55:20 -08:00
reuseport_bpf_cpu.c
reuseport_bpf_numa.c
reuseport_bpf.c
reuseport_dualstack.c
rtnetlink.sh selftests: rtnetlink: Add a test case for multipath route get 2018-12-20 16:42:39 -08:00
run_afpackettests selftests/net: add txring_overwrite 2018-11-24 18:22:21 -08:00
run_netsocktests
socket.c
tcp_inq.c
tcp_mmap.c
test_bpf.sh
test_vxlan_fdb_changelink.sh selftests: net: Add test_vxlan_fdb_changelink.sh 2018-12-18 21:18:26 -08:00
test_vxlan_under_vrf.sh test/net: Add script for VXLAN underlay in a VRF 2018-12-03 14:16:01 -08:00
tls.c
txring_overwrite.c selftests/net: add txring_overwrite 2018-11-24 18:22:21 -08:00
udpgro_bench.sh selftests: add functionals test for UDP GRO 2018-11-07 16:23:05 -08:00
udpgro.sh selftests: add explicit test for multiple concurrent GRO sockets 2018-11-16 23:03:20 -08:00
udpgso_bench_rx.c selftests: add functionals test for UDP GRO 2018-11-07 16:23:05 -08:00
udpgso_bench_tx.c selftests: add functionals test for UDP GRO 2018-11-07 16:23:05 -08:00
udpgso_bench.sh selftests: extend zerocopy tests to udp 2018-12-03 15:58:32 -08:00
udpgso.c
udpgso.sh
xfrm_policy.sh xfrm: policy: fix netlink/pf_key policy lookups 2018-11-15 18:09:32 +01:00