Paolo Abeni 0226436acf mptcp: do not rely on implicit state check in mptcp_listen() ... Since the blamed commit, closing the first subflow resets the first subflow socket state to SS_UNCONNECTED. The current mptcp listen implementation relies only on such state to prevent touching not-fully-disconnected sockets. Incoming mptcp fastclose (or paired endpoint removal) unconditionally closes the first subflow. All the above allows an incoming fastclose followed by a listen() call to successfully race with a blocking recvmsg(), potentially causing the latter to hit a divide by zero bug in cleanup_rbuf/__tcp_select_window(). Address the issue explicitly checking the msk socket state in mptcp_listen(). An alternative solution would be moving the first subflow socket state update into mptcp_disconnect(), but in the long term the first subflow socket should be removed: better avoid relaying on it for internal consistency check. Fixes: b29fcfb54c ("mptcp: full disconnect implementation") Cc: stable@vger.kernel.org Reported-by: Christoph Paasch <cpaasch@apple.com> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/414 Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-07-05 10:51:14 +01:00
..
bpf.c
crypto_test.c
crypto.c
ctrl.c
diag.c
fastopen.c
Kconfig
Makefile
mib.c
mib.h
mptcp_diag.c
options.c
pm_netlink.c
pm_userspace.c
pm.c
protocol.c	mptcp: do not rely on implicit state check in mptcp_listen()	2023-07-05 10:51:14 +01:00
protocol.h
sockopt.c
subflow.c
syncookies.c
token_test.c
token.c