stuartl/linux-stable
1
0
Fork 0
mirror of https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable.git synced 2025-09-15 11:28:36 +10:00
Code Issues Releases Wiki Activity

ceph: remove unnecessary IS_ERR() check in ceph_fname_to_usr()

Browse Source 
Before returning, function ceph_fname_to_usr() does a final IS_ERR() check
in 'dir':

	if ((dir != fname->dir) && !IS_ERR(dir)) {...}

This check is unnecessary because, if the 'dir' variable has changed to
something other than 'fname->dir' (it's initial value), that error check has
been performed already and, if there was indeed an error, it would have
been returned immediately.

Besides, this useless IS_ERR() is also confusing static analysis tools.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202309282202.xZxGdvS3-lkp@intel.com/
Signed-off-by: Luis Henriques <lhenriques@suse.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
Luis Henriques 2023-09-29 10:12:06 +01:00 committed by Ilya Dryomov
parent 15c0a870dc
commit 42b71826fe
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ceph/crypto.c
View File

@ -460,7 +460,7 @@ int ceph_fname_to_usr(const struct ceph_fname *fname, struct fscrypt_str *tname,
out: out:
fscrypt_fname_free_buffer(&_tname); fscrypt_fname_free_buffer(&_tname);
out_inode: out_inode:
if ((dir != fname->dir) && !IS_ERR(dir)) { if (dir != fname->dir) {
if ((dir->i_state & I_NEW)) if ((dir->i_state & I_NEW))
discard_new_inode(dir); discard_new_inode(dir);
else else