stuartl/linux-stable
1
0
Fork 0
mirror of https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable.git synced 2025-09-14 11:19:08 +10:00
Code Issues Releases Wiki Activity

bcachefs: bch2_ioctl_subvolume_destroy() fixes

Browse Source 
[ Upstream commit 707549600c ]

bch2_evict_subvolume_inodes() was getting stuck - due to incorrectly
pruning the dcache.

Also, fix missing permissions checks.

Reported-by: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kent Overstreet 2025-03-29 19:01:09 -04:00 committed by Greg Kroah-Hartman
parent a964484a35
commit 9e6e83e1e2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/bcachefs/fs-ioctl.c
View File

@ -520,10 +520,12 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp,
ret = -ENOENT; ret = -ENOENT;
goto err; goto err;
} }
ret = __bch2_unlink(dir, victim, true);
ret = inode_permission(file_mnt_idmap(filp), d_inode(victim), MAY_WRITE) ?:
__bch2_unlink(dir, victim, true);
if (!ret) { if (!ret) {
fsnotify_rmdir(dir, victim); fsnotify_rmdir(dir, victim);
d_delete(victim); d_invalidate(victim);
} }
err: err:
inode_unlock(dir); inode_unlock(dir);