stuartl/linux-stable
1
0
Fork 0
mirror of https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable.git synced 2025-11-07 11:34:03 +10:00
Code Issues Releases Wiki Activity

spi: slave: Fix missing break in switch

Browse Source 
Apparently, this code does not actually fall through to the next case
because the machine restarts before it has a chance. However, for the
sake of maintenance and readability, we better add the missing break
statement.

Addresses-Coverity-ID: 1437892 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Gustavo A. R. Silva 2018-10-03 14:33:28 +02:00 committed by Mark Brown
parent aeb8a43fa2
commit c24bfa8f21
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/spi/spi-slave-system-control.c
View File

@ -60,6 +60,7 @@ static void spi_slave_system_control_complete(void *arg)
case CMD_REBOOT: case CMD_REBOOT:
dev_info(&priv->spi->dev, "Rebooting system...\n"); dev_info(&priv->spi->dev, "Rebooting system...\n");
kernel_restart(NULL); kernel_restart(NULL);
break;
case CMD_POWEROFF: case CMD_POWEROFF:
dev_info(&priv->spi->dev, "Powering off system...\n"); dev_info(&priv->spi->dev, "Powering off system...\n");