David Hildenbrand 517f496e1e mm/gup: revert "mm: gup: fix infinite loop within __get_longterm_locked" ... After commit 1aaf8c1229 ("mm: gup: fix infinite loop within __get_longterm_locked") we are able to longterm pin folios that are not supposed to get longterm pinned, simply because they temporarily have the LRU flag cleared (esp. temporarily isolated). For example, two __get_longterm_locked() callers can race, or __get_longterm_locked() can race with anything else that temporarily isolates folios. The introducing commit mentions the use case of a driver that uses vm_ops->fault to insert pages allocated through cma_alloc() into the page tables, assuming they can later get longterm pinned. These pages/ folios would never have the LRU flag set and consequently cannot get isolated. There is no known in-tree user making use of that so far, fortunately. To handle that in the future -- and avoid retrying forever to isolate/migrate them -- we will need a different mechanism for the CMA area *owner* to indicate that it actually already allocated the page and is fine with longterm pinning it. The LRU flag is not suitable for that. Probably we can lookup the relevant CMA area and query the bitmap; we only have have to care about some races, probably. If already allocated, we could just allow longterm pinning) Anyhow, let's fix the "must not be longterm pinned" problem first by reverting the original commit. Link: https://lkml.kernel.org/r/20250611131314.594529-1-david@redhat.com Fixes: 1aaf8c1229 ("mm: gup: fix infinite loop within __get_longterm_locked") Signed-off-by: David Hildenbrand <david@redhat.com> Closes: https://lore.kernel.org/all/20250522092755.GA3277597@tiffany/ Reported-by: Hyesoo Yu <hyesoo.yu@samsung.com> Reviewed-by: John Hubbard <jhubbard@nvidia.com> Cc: Jason Gunthorpe <jgg@ziepe.ca> Cc: Peter Xu <peterx@redhat.com> Cc: Zhaoyang Huang <zhaoyang.huang@unisoc.com> Cc: Aijun Sun <aijun.sun@unisoc.com> Cc: Alistair Popple <apopple@nvidia.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2025-06-19 20:48:01 -07:00
..
damon	Revert "mm/damon/Kconfig: enable CONFIG_DAMON by default"	2025-06-10 10:22:15 -07:00
kasan	hardening updates for v6.16-rc1	2025-05-28 07:47:10 -07:00
kfence
kmsan	kmsan: test: add module description	2025-06-05 22:02:25 -07:00
backing-dev.c
balloon_compaction.c
bootmem_info.c
cma_debug.c
cma_sysfs.c
cma.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
cma.h	mm: cma: set early_pfn and bitmap as a union in cma_memrange	2025-05-22 14:55:36 -07:00
compaction.c	mm: page_alloc: tighten up find_suitable_fallback()	2025-05-11 17:48:18 -07:00
debug_page_alloc.c	mm/debug_page_alloc: improve error message for invalid guardpage minorder	2025-05-12 23:50:38 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm: remove mk_huge_pte()	2025-05-11 17:48:04 -07:00
debug.c	mm/debug: fix parameter passed to page_mapcount_is_type()	2025-05-11 17:48:17 -07:00
dmapool_test.c
dmapool.c	dmapool: add NUMA affinity support	2025-05-20 05:34:27 +02:00
early_ioremap.c
execmem.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
fadvise.c
fail_page_alloc.c
failslab.c
filemap.c	- The 2 patch series "zram: support algorithm-specific parameters" from	2025-06-02 16:00:26 -07:00
folio-compat.c
gup_test.c
gup_test.h
gup.c	mm/gup: revert "mm: gup: fix infinite loop within __get_longterm_locked"	2025-06-19 20:48:01 -07:00
highmem.c
hmm.c	RDMA/core: Avoid hmm_dma_map_alloc() for virtual DMA devices	2025-05-25 06:24:21 -04:00
huge_memory.c	mm: convert track_pfn_insert() to pfnmap_setup_cachemode*()	2025-05-22 14:55:36 -07:00
hugetlb_cgroup.c
hugetlb_cma.c	mm/hugetlb: use separate nodemask for bootmem allocations	2025-05-12 23:50:35 -07:00
hugetlb_cma.h
hugetlb_vmemmap.c	mm, hugetlb: increment the number of pages to be reset on HVO	2025-04-17 20:10:08 -07:00
hugetlb_vmemmap.h
hugetlb.c	mm/hugetlb: fix huge_pmd_unshare() vs GUP-fast race	2025-06-05 22:02:24 -07:00
hwpoison-inject.c
init-mm.c
internal.h	mm: move dup_mmap() to mm	2025-05-12 23:50:48 -07:00
interval_tree.c
io-mapping.c	mm/io-mapping: track_pfn() -> "pfnmap tracking"	2025-05-22 14:55:37 -07:00
ioremap.c
Kconfig	LoongArch changes for v6.16	2025-06-07 09:56:18 -07:00
Kconfig.debug
khugepaged.c	mm/khugepaged: clean up refcount check using folio_expected_ref_count()	2025-05-31 22:46:16 -07:00
kmemleak.c	mm: kmemleak: mark variables as __read_mostly	2025-05-12 23:50:47 -07:00
ksm.c
list_lru.c
maccess.c	maccess: fix strncpy_from_user_nofault() empty string handling	2025-05-11 17:54:10 -07:00
madvise.c	mm: close theoretical race where stale TLB entries could linger	2025-06-11 22:42:35 -07:00
Makefile	mm: perform VMA allocation, freeing, duplication in mm	2025-05-12 23:50:48 -07:00
mapping_dirty_helpers.c
memblock.c	memblock: add KHO support for reserve_mem	2025-05-12 23:50:42 -07:00
memcontrol-v1.c	memcg: make count_memcg_events re-entrant safe against irqs	2025-05-22 14:55:38 -07:00
memcontrol-v1.h
memcontrol.c	- The 2 patch series "zram: support algorithm-specific parameters" from	2025-06-02 16:00:26 -07:00
memfd.c	mm: move folio_index to mm/swap.h and remove no longer needed helper	2025-05-12 23:50:50 -07:00
memory_hotplug.c	mm: use for_each_valid_pfn() in memory_hotplug	2025-05-12 23:50:44 -07:00
memory-failure.c
memory-tiers.c
memory.c	mm/shmem, swap: fix softlockup with mTHP swapin	2025-06-19 20:48:01 -07:00
mempolicy.c	mm/mempolicy: fix incorrect freeing of wi_kobj	2025-06-05 22:02:23 -07:00
mempool.c
memremap.c	mm: introduce pfnmap_track() and pfnmap_untrack() and use them for memremap	2025-05-22 14:55:37 -07:00
memtest.c
migrate_device.c
migrate.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
mincore.c	mm: mincore: use pte_batch_hint() to batch process large folios	2025-05-22 14:55:36 -07:00
mlock.c
mm_init.c	- The 2 patch series "zram: support algorithm-specific parameters" from	2025-06-02 16:00:26 -07:00
mm_slot.h
mmap_lock.c	mm: move mmap/vma locking logic into specific files	2025-05-11 17:48:33 -07:00
mmap.c	mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()	2025-05-22 14:55:37 -07:00
mmu_gather.c	mmu_gather: move tlb flush for VM_PFNMAP/VM_MIXEDMAP vmas into free_pgtables()	2025-05-31 22:46:12 -07:00
mmu_notifier.c	Update Christoph's Email address and make it consistent	2025-05-12 23:50:31 -07:00
mmzone.c
mprotect.c	mm/huge_memory: remove useless folio pointers passing	2025-05-12 23:50:34 -07:00
mremap.c	mm: expose abnormal new_pte during move_ptes	2025-06-05 21:55:41 -07:00
mseal.c
msync.c
nommu.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
numa_emulation.c
numa_memblks.c	mm: numa_memblks: introduce numa_add_reserved_memblk	2025-05-22 14:55:36 -07:00
numa.c	mm/numa: remove unnecessary local variable in alloc_node_data()	2025-05-12 23:50:38 -07:00
oom_kill.c
page_alloc.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
page_counter.c
page_ext.c
page_frag_cache.c
page_idle.c
page_io.c
page_isolation.c
page_owner.c	mm: rename try_alloc_pages() to alloc_pages_nolock()	2025-05-22 14:55:37 -07:00
page_poison.c
page_reporting.c
page_reporting.h
page_table_check.c	mm/page_table_check: Batch-check pmds/puds just like ptes	2025-05-09 13:43:07 +01:00
page_vma_mapped.c
page-writeback.c	treewide, timers: Rename from_timer() to timer_container_of()	2025-06-08 09:07:37 +02:00
pagewalk.c
percpu-internal.h
percpu-km.c
percpu-stats.c
percpu-vm.c
percpu.c
pgalloc-track.h
pgtable-generic.c
process_vm_access.c
pt_reclaim.c
ptdump.c	mm/ptdump: split effective_prot() into level specific callbacks	2025-05-11 17:48:19 -07:00
readahead.c	fs: add S_ANON_INODE	2025-04-21 13:20:14 +02:00
rmap.c	mm/rmap: fix typo in comment in page_address_in_vma	2025-05-12 23:50:37 -07:00
rodata_test.c
secretmem.c	mm: secretmem: convert to .mmap_prepare() hook	2025-05-13 16:28:07 -07:00
shmem_quota.c
shmem.c	mm/shmem, swap: fix softlockup with mTHP swapin	2025-06-19 20:48:01 -07:00
show_mem.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
shrinker_debug.c
shrinker.c
shuffle.c
shuffle.h
slab_common.c	Update Christoph's Email address and make it consistent	2025-05-12 23:50:31 -07:00
slab.h
slub.c	slab updates for 6.16	2025-06-04 08:59:59 -07:00
sparse-vmemmap.c
sparse.c
swap_cgroup.c
swap_state.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
swap.c	memcg: make count_memcg_events re-entrant safe against irqs	2025-05-22 14:55:38 -07:00
swap.h	mm/shmem, swap: fix softlockup with mTHP swapin	2025-06-19 20:48:01 -07:00
swapfile.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
truncate.c	- The 2 patch series "zram: support algorithm-specific parameters" from	2025-06-02 16:00:26 -07:00
usercopy.c
userfaultfd.c	mm: add folio_mk_pte()	2025-05-11 17:48:03 -07:00
util.c	mm: add mmap_prepare() compatibility layer for nested file systems	2025-06-12 21:39:02 -07:00
vma_exec.c	mm: abstract initial stack setup to mm subsystem	2025-05-12 23:50:48 -07:00
vma_init.c	mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()	2025-05-22 14:55:37 -07:00
vma_internal.h
vma.c	mm: add mmap_prepare() compatibility layer for nested file systems	2025-06-12 21:39:02 -07:00
vma.h	mm: add mmap_prepare() compatibility layer for nested file systems	2025-06-12 21:39:02 -07:00
vmalloc.c	- The 11 patch series "Add folio_mk_pte()" from Matthew Wilcox	2025-05-31 15:44:16 -07:00
vmpressure.c
vmscan.c	fuse update for 6.16	2025-06-02 15:31:05 -07:00
vmstat.c	mm: fix vmstat after removing NR_BOUNCE	2025-06-05 22:02:22 -07:00
workingset.c	mm: workingset: simplify lockdep check in update_node	2025-05-12 23:50:44 -07:00
zpdesc.h	mm: rename page->index to page->__folio_index	2025-05-31 22:46:06 -07:00
zpool.c	zsmalloc: prefer the the original page's node for compressed data	2025-05-11 17:48:06 -07:00
zsmalloc.c	zsmalloc: cleanup headers includes	2025-05-11 17:48:16 -07:00
zswap.c	zsmalloc: prefer the the original page's node for compressed data	2025-05-11 17:48:06 -07:00