mirror of
				https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable.git
				synced 2025-11-04 07:44:51 +10:00 
			
		
		
		
	The jitterentropy's Repetition Count Test (RCT) as well as the Adaptive Proportion Test (APT) are run unconditionally on any collected samples. However, their result, i.e. ->health_failure, will only get checked if fips_enabled is set, c.f. the jent_health_failure() wrapper. I would argue that a RCT or APT failure indicates that something's seriously off and that this should always be reported as an error, independently of whether FIPS mode is enabled or not: it should be up to callers whether or not and how to handle jitterentropy failures. Make jent_health_failure() to unconditionally return ->health_failure, independent of whether fips_enabled is set. Note that fips_enabled isn't accessed from the jitterentropy code anymore now. Remove the linux/fips.h include as well as the jent_fips_enabled() wrapper. Signed-off-by: Nicolai Stange <nstange@suse.de> Reviewed-by: Stephan Mueller <smueller@chronox.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
		
			
				
	
	
		
			17 lines
		
	
	
		
			607 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			17 lines
		
	
	
		
			607 B
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0-or-later
 | 
						|
 | 
						|
extern void *jent_zalloc(unsigned int len);
 | 
						|
extern void jent_zfree(void *ptr);
 | 
						|
extern void jent_panic(char *s);
 | 
						|
extern void jent_memcpy(void *dest, const void *src, unsigned int n);
 | 
						|
extern void jent_get_nstime(__u64 *out);
 | 
						|
 | 
						|
struct rand_data;
 | 
						|
extern int jent_entropy_init(void);
 | 
						|
extern int jent_read_entropy(struct rand_data *ec, unsigned char *data,
 | 
						|
			     unsigned int len);
 | 
						|
 | 
						|
extern struct rand_data *jent_entropy_collector_alloc(unsigned int osr,
 | 
						|
						      unsigned int flags);
 | 
						|
extern void jent_entropy_collector_free(struct rand_data *entropy_collector);
 |