linux-stable/net/mptcp
Eric Dumazet 0c5eba454e net: lockless sock_i_ino()
[ Upstream commit 5d6b58c932 ]

Followup of commit c51da3f7a1 ("net: remove sock_i_uid()")

A recent syzbot report was the trigger for this change.

Over the years, we had many problems caused by the
read_lock[_bh](&sk->sk_callback_lock) in sock_i_uid().

We could fix smc_diag_dump_proto() or make a more radical move:

Instead of waiting for new syzbot reports, cache the socket
inode number in sk->sk_ino, so that we no longer
need to acquire sk->sk_callback_lock in sock_i_ino().

This makes socket dumps faster (one less cache line miss,
and two atomic ops avoided).

Prior art:

commit 25a9c8a443 ("netlink: Add __sock_i_ino() for __netlink_diag_dump().")
commit 4f9bf2a2f5 ("tcp: Don't acquire inet_listen_hashbucket::lock with disabled BH.")
commit efc3dbc374 ("rds: Make rds_sock_lock BH rather than IRQ safe.")

Fixes: d2d6422f8b ("x86: Allow to enable PREEMPT_RT.")
Reported-by: syzbot+50603c05bbdf4dfdaffa@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/68b73804.050a0220.3db4df.01d8.GAE@google.com/T/#u
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20250902183603.740428-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-09-09 19:02:26 +02:00
..
bpf.c
crypto_test.c
crypto.c
ctrl.c
diag.c
fastopen.c
Kconfig
Makefile
mib.c
mib.h
mptcp_diag.c
mptcp_pm_gen.c
mptcp_pm_gen.h
options.c mptcp: drop skb if MPTCP skb extension allocation fails 2025-08-28 16:34:32 +02:00
pm_kernel.c mptcp: pm: kernel: flush: do not reset ADD_ADDR limit 2025-08-28 16:34:32 +02:00
pm_netlink.c
pm_userspace.c
pm.c mptcp: disable add_addr retransmission when timeout is 0 2025-08-28 16:34:32 +02:00
protocol.c net: lockless sock_i_ino() 2025-09-09 19:02:26 +02:00
protocol.h mptcp: plug races between subflow fail and subflow creation 2025-07-15 17:31:25 -07:00
sched.c
sockopt.c
subflow.c mptcp: plug races between subflow fail and subflow creation 2025-07-15 17:31:25 -07:00
syncookies.c
token_test.c
token.c