Jakob Unterwurzacher 5174ea81d6 net: dsa: microchip: linearize skb for tail-tagging switches ... [ Upstream commit ba54bce747 ] The pointer arithmentic for accessing the tail tag only works for linear skbs. For nonlinear skbs, it reads uninitialized memory inside the skb headroom, essentially randomizing the tag. I have observed it gets set to 6 most of the time. Example where ksz9477_rcv thinks that the packet from port 1 comes from port 6 (which does not exist for the ksz9896 that's in use), dropping the packet. Debug prints added by me (not included in this patch): [ 256.645337] ksz9477_rcv:323 tag0=6 [ 256.645349] skb len=47 headroom=78 headlen=0 tailroom=0 mac=(64,14) mac_len=14 net=(78,0) trans=78 shinfo(txflags=0 nr_frags=1 gso(size=0 type=0 segs=0)) csum(0x0 start=0 offset=0 ip_summed=0 complete_sw=0 valid=0 level=0) hash(0x0 sw=0 l4=0) proto=0x00f8 pkttype=1 iif=3 priority=0x0 mark=0x0 alloc_cpu=0 vlan_all=0x0 encapsulation=0 inner(proto=0x0000, mac=0, net=0, trans=0) [ 256.645377] dev name=end1 feat=0x0002e10200114bb3 [ 256.645386] skb headroom: 00000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 256.645395] skb headroom: 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 256.645403] skb headroom: 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 256.645411] skb headroom: 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 256.645420] skb headroom: 00000040: ff ff ff ff ff ff 00 1c 19 f2 e2 db 08 06 [ 256.645428] skb frag: 00000000: 00 01 08 00 06 04 00 01 00 1c 19 f2 e2 db 0a 02 [ 256.645436] skb frag: 00000010: 00 83 00 00 00 00 00 00 0a 02 a0 2f 00 00 00 00 [ 256.645444] skb frag: 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 [ 256.645452] ksz_common_rcv:92 dsa_conduit_find_user returned NULL Call skb_linearize before trying to access the tag. This patch fixes ksz9477_rcv which is used by the ksz9896 I have at hand, and also applies the same fix to ksz8795_rcv which seems to have the same problem. Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@cherry.de> CC: stable@vger.kernel.org Fixes: 016e43a26b ("net: dsa: ksz: Add KSZ8795 tag code") Fixes: 8b8010fb78 ("dsa: add support for Microchip KSZ tail tagging") Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Link: https://patch.msgid.link/20250515072920.2313014-1-jakob.unterwurzacher@cherry.de Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2025-09-09 18:56:31 +02:00
..
6lowpan
9p
802
8021q
appletalk
atm	net: atm: fix memory leak in atm_register_sysfs when device_register fail	2025-09-09 18:56:25 +02:00
ax25	ax25: properly unshare skbs in ax25_kiss_rcv()	2025-09-09 18:56:25 +02:00
batman-adv	batman-adv: fix OOB read/write in network-coding decode	2025-09-09 18:56:27 +02:00
bluetooth	Bluetooth: Fix use-after-free in l2cap_sock_cleanup_listen()	2025-09-09 18:56:21 +02:00
bpf
bpfilter
bridge	netfilter: br_netfilter: do not check confirmed bit in br_nf_local_in() after confirm	2025-09-09 18:56:21 +02:00
caif	caif: reduce stack size, again	2025-08-15 12:08:45 +02:00
can
ceph
core	net: gso: Forbid IPv6 TSO with extensions on devices with only IPV6_CSUM	2025-08-28 16:28:48 +02:00
dcb
dccp
devlink
dns_resolver
dsa	net: dsa: microchip: linearize skb for tail-tagging switches	2025-09-09 18:56:31 +02:00
ethernet
ethtool
handshake
hsr	net, hsr: reject HSR frame if skb can't hold tag	2025-08-28 16:28:39 +02:00
ieee802154
ife
ipv4	ipv4: Fix NULL vs error pointer check in inet_blackhole_dev_init()	2025-09-09 18:56:24 +02:00
ipv6	icmp: fix icmp_ndo_send address translation for reply direction	2025-09-09 18:56:22 +02:00
iucv
kcm
key
l2tp
l3mdev
lapb
llc
mac80211	wifi: mac80211: check basic rates validity in sta_link_apply_parameters	2025-08-28 16:28:41 +02:00
mac802154
mctp	mctp: return -ENOPROTOOPT for unknown getsockopt options	2025-09-09 18:56:24 +02:00
mpls
mptcp	mptcp: disable add_addr retransmission when timeout is 0	2025-08-28 16:28:44 +02:00
ncsi	net: ncsi: Fix buffer overflow in fetching version id	2025-08-28 16:28:24 +02:00
netfilter	netfilter: conntrack: helper: Replace -EEXIST by -EBUSY	2025-09-09 18:56:21 +02:00
netlabel
netlink	netlink: add variable-length / auto integers	2025-09-09 18:56:22 +02:00
netrom
nfc
nsh
openvswitch
packet	net/packet: fix a race in packet_set_ring() and packet_notifier()	2025-08-15 12:09:05 +02:00
phonet
psample
qrtr
rds	net: better track kernel sockets lifetime	2025-08-28 16:28:39 +02:00
rfkill
rose	net: rose: fix a typo in rose_clear_routes()	2025-09-04 15:30:28 +02:00
rxrpc
sched	net/sched: Remove unnecessary WARNING condition for empty child qdisc in htb_activate	2025-08-28 16:28:49 +02:00
sctp	sctp: initialize more fields in sctp_v6_from_sk()	2025-09-04 15:30:26 +02:00
smc	net/smc: Remove validation of reserved bits in CLC Decline message	2025-09-09 18:56:24 +02:00
strparser
sunrpc	net: better track kernel sockets lifetime	2025-08-28 16:28:39 +02:00
switchdev
tipc
tls	tls: fix handling of zero-length records on the rx_list	2025-08-28 16:28:46 +02:00
unix
vmw_vsock	vsock/virtio: Validate length in packet header before skb_put()	2025-08-28 16:28:36 +02:00
wireless	wifi: cfg80211: sme: cap SSID length in __cfg80211_connect_result()	2025-09-09 18:56:24 +02:00
x25
xdp
xfrm	xfrm: Duplicate SPI Handling	2025-08-28 16:28:22 +02:00
compat.c
devres.c
Kconfig
Kconfig.debug
Makefile
socket.c
sysctl_net.c